Skip to content

chore: add build_and_push target to makefile#18

Merged
a-klos merged 4 commits intomainfrom
chore/add-build-push-makefile
May 28, 2025
Merged

chore: add build_and_push target to makefile#18
a-klos merged 4 commits intomainfrom
chore/add-build-push-makefile

Conversation

@a-klos
Copy link
Copy Markdown
Member

@a-klos a-klos commented May 23, 2025

This pull request introduces a new build_and_push target in the Makefile to streamline the process of building and pushing Docker images for various components of the project. It also defines two new variables, IMAGE_TAG and REGISTRY, to allow customization of the image tags and registry.

Additions to the Makefile:

  • New build_and_push target: Automates the Docker build and push process for the following components:

    • rag-backend
    • admin-backend
    • document-extractor
    • frontend (chat app)
    • admin-frontend (admin app)
  • New variables:

    • IMAGE_TAG: Allows specifying the Docker image version (default: v1.0.0).
    • REGISTRY: Enables setting a custom Docker registry.

huhn511
huhn511 previously approved these changes May 23, 2025
Copy link
Copy Markdown
Collaborator

@huhn511 huhn511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT 👍

Copy link
Copy Markdown
Collaborator

@huhn511 huhn511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still LGTM! 👍

@a-klos a-klos merged commit e3e1fcc into main May 28, 2025
5 checks passed
@a-klos a-klos deleted the chore/add-build-push-makefile branch May 28, 2025 05:10
a-klos added a commit that referenced this pull request Jul 3, 2025
Configuration of a timeout parameter is possible. defaults to 1h.
a-klos added a commit that referenced this pull request Jul 3, 2025
* feat: Update langfuse dependency to version 3.0.0 and adjust related imports

- Updated langfuse version in pyproject.toml and poetry.lock files.
- Modified import statements in langfuse_ragas_evaluator.py to reflect new package structure.
- Adjusted langfuse_manager.py to use labels instead of is_active for prompt management.
- Refactored langfuse_traced_chain.py to utilize the new CallbackHandler import.
- Enhanced traced_chain.py to initialize langfuse client and update tracing logic.

* Add comprehensive tests for PDFExtractor functionality

- Introduced test suite for enhanced PDF extraction capabilities in `test_enhanced_pdfs.py`.
- Created new test files for various PDF types including text-based, mixed content, and scanned documents.
- Implemented detailed tests for PDFExtractor's classification, extraction, and linking functionalities in `test_pdf_extractorv2_new.py`.
- Added quick functionality verification tests in `test_pdf_functionality.py` to ensure correct operation with real PDF files.
- Established mock classes and fixtures to facilitate unit testing of PDF extraction methods.

* feat: Update dependencies and modify PDF extractor import

- Added a new source for PyTorch and its related packages with CPU support in pyproject.toml.
- Included additional dependencies: camelot-py, tabula, and easyocr.
- Changed the import statement for PDFExtractor to use the new version (pdf_extractorv2) in dependency_container.py.

* feat: add pytest-asyncio support for asynchronous testing

* Refactor PDF extractor tests: remove old test files and implement comprehensive test suite for PDFExtractor class

- Deleted outdated test files: test_pdf_extractorv2.py, test_pdf_extractorv2_new.py, and test_pdf_functionality.py.
- Introduced a new comprehensive test suite for the PDFExtractor class, covering various functionalities including content extraction from different PDF types, error handling, and performance testing.
- Added mock dependencies and fixtures to streamline testing processes.
- Implemented tests for text extraction, table extraction, language detection, and related ID mapping.
- Ensured compatibility with multiple PDF formats and validated metadata completeness in extracted content.

* refactor: Moved tests from test_pdf_extractor.py to pdf_extractor_test.py, ensuring comprehensive coverage and maintaining functionality. Removed old test file to streamline the testing structure.

* refactor: update flake8 exclusions and clean up PDFExtractor tests for improved readability and maintainability

* chore: add pdf files using git lfs

* refactor: update parameter names in PDFExtractor class for clarity and consistency; enhance test suite with additional logging and assertions

* chore: remove PyTorch and related dependencies from pyproject.toml

* refactor: remove unused text-based PDF document from test data

* chore: add sample PDF document for testing in extractor-api-lib

* refactor: remove unused test methods and main execution block from pdf_extractor_test.py

* chore: add pytest-asyncio as a development dependency

* Remove unused dependencies: tabula and easyocr from pyproject.toml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants